test(unit-tests): improve reliability of message consumption in tests#1711
Open
jeanouii wants to merge 4 commits intoapache:mainfrom
Open
test(unit-tests): improve reliability of message consumption in tests#1711jeanouii wants to merge 4 commits intoapache:mainfrom
jeanouii wants to merge 4 commits intoapache:mainfrom
Conversation
jeanouii
force-pushed
the
fix/flaky-tests
branch
2 times, most recently
from
38400ee to
75627fb
Compare
… races Two race conditions caused testEvictionXA to fail intermittently: 1. Exception event propagation: ActiveMQConnection.addTransportListener() callbacks fire via executeAsync(), which silently drops tasks when the pool's ExceptionListener closes the connection and shuts down the executor first. Fixed by intercepting at the MockTransport level where exception propagation is synchronous. 2. Pool eviction timing: The pool evicts broken connections asynchronously via ExceptionListener fired through executeAsync(). The test could request a new connection before eviction completed. Fixed by using Wait.waitFor() retry pattern (consistent with other pool tests).
jeanouii
force-pushed
the
fix/flaky-tests
branch
from
75627fb to
a639a48
Compare
jeanouii
commented
Feb 25, 2026
Contributor
Author
jeanouii
left a comment
jeanouii
left a comment
There was a problem hiding this comment.
Small comment bellow
| try (final PooledConnection connection = (PooledConnection) pooledFactory.createConnection()) { | ||
| final ActiveMQConnection amqC = (ActiveMQConnection) connection.getConnection(); | ||
| amqC.addTransportListener(new TransportListener() { | ||
| // Intercept exception propagation at the MockTransport level where it fires |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.