Skip to content

Improve exception context in BrokerService preDestroy #1707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pradeep85841 wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −1
Open

Improve exception context in BrokerService preDestroy #1707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee00221
Improve exception context in BrokerService preDestroy
Feb 21, 2026
f4a6d22
Fix CI failure in testPriorityMessagesWithJmsBrowser
pradeep85841 Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion activemq-broker/src/main/java/org/apache/activemq/broker/BrokerService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -788,7 +788,7 @@ private void preDestroy () {
try {
stop();
} catch (Exception ex) {
throw new RuntimeException();
throw new RuntimeException("Exception during broker preDestroy cleanup: " + getBrokerName(), ex);
}
}

Expand Down
4 changes: 4 additions & 0 deletions ...src/test/java/org/apache/activemq/usecases/QueueZeroPrefetchLazyDispatchPriorityTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,10 @@ public void testPriorityMessagesWithJmsBrowser() throws Exception {
final ArrayList<Message> consumeList = consumeMessages("TestQ");
LOG.info("Consumed list {}", consumeList.size());

// wait until remaining messages are actually consumed
assertTrue("Remaining messages consumed",
Wait.waitFor(() -> consumeList.size() == numToSend - 1, 5000, 100));

// compare lists
// assertEquals("Iteration: " + i
// +", message 1 should be priority high", 5,
Expand Down