-
Notifications
You must be signed in to change notification settings - Fork 491
Unified --Json output #6419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Unified --Json output #6419
Changes from all commits
6297333
9e8d477
bac6e17
6e556f5
9d9f301
f08ddb9
92b9944
0d10159
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,122 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.accumulo.core.cli; | ||
|
|
||
| import java.time.ZoneOffset; | ||
| import java.time.ZonedDateTime; | ||
| import java.time.format.DateTimeFormatter; | ||
|
|
||
| import com.google.gson.Gson; | ||
|
|
||
| /** | ||
| * A stable, versioned outer wrapper for all admin command JSON output. | ||
| * | ||
| * <p> | ||
| * Every command that supports --json output wraps its command-specific data in this envelope. This | ||
| * provides a consistent structure that scripts can rely on regardless of which command produced the | ||
| * output: | ||
| * | ||
| * <pre> | ||
| * { | ||
| * "command": "accumulo admin fate --summary", | ||
| * "version": "1", | ||
| * "reportTime": "2026-06-04T12:00:00Z", | ||
| * "status": "OK", | ||
| * "message": null, | ||
| * "data": { ...command-specific payload... } | ||
| * } | ||
| * </pre> | ||
| * | ||
| * <p> | ||
| * The {@link version} field is a stability contract. When a breaking change is made to the envelope | ||
| * structure, the version will be incremented. Scripts should check this field and handle the | ||
| * version they were written against. | ||
| * | ||
| */ | ||
| public class CommandOutputEnvelope { | ||
|
|
||
| /** | ||
| * Current envelop schema version. Increment this if a breaking structural change is made to the | ||
| * envelope fields (not to the {@link data} field, data changes command specific). | ||
| */ | ||
| public static final String VERSION = "1.0"; | ||
| private static final DateTimeFormatter ISO_FMT = | ||
| DateTimeFormatter.ofPattern("yyyy-MM-dd'T'HH:mm:ss'Z'"); | ||
|
Comment on lines
+59
to
+60
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I wonder if it would be more user friendly to use the hosts timezone. |
||
| private static final Gson PRETTY_GSON = | ||
| new Gson().newBuilder().setPrettyPrinting().disableJdkUnsafe().create(); | ||
|
|
||
| private String command; | ||
| private String version; | ||
| private String reportTime; | ||
| private String status; | ||
| private String message; | ||
| private Object data; | ||
|
|
||
| @SuppressWarnings("unused") | ||
| private CommandOutputEnvelope() {} | ||
|
|
||
| private CommandOutputEnvelope(String command, String status, String message, Object data) { | ||
| this.command = command; | ||
| this.version = VERSION; | ||
| this.reportTime = ISO_FMT.format(ZonedDateTime.now(ZoneOffset.UTC)); | ||
| this.status = status; | ||
| this.message = message; | ||
|
Comment on lines
+78
to
+79
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Might be able to combine these two fields into one. For success the value could be |
||
| this.data = data; | ||
| } | ||
|
|
||
| public static CommandOutputEnvelope of(String command, Object data) { | ||
| return new CommandOutputEnvelope(command, "OK", null, data); | ||
| } | ||
|
|
||
| public static CommandOutputEnvelope error(String command, String message) { | ||
| return new CommandOutputEnvelope(command, "ERROR", message, null); | ||
| } | ||
|
|
||
| public String toJson() { | ||
| return PRETTY_GSON.toJson(this); | ||
| } | ||
|
|
||
| public static CommandOutputEnvelope fromJson(String json) { | ||
| return PRETTY_GSON.fromJson(json, CommandOutputEnvelope.class); | ||
| } | ||
|
|
||
| public String getCommand() { | ||
| return command; | ||
| } | ||
|
|
||
| public String getVersion() { | ||
| return version; | ||
| } | ||
|
|
||
| public String getReportTime() { | ||
| return reportTime; | ||
| } | ||
|
|
||
| public String getStatus() { | ||
| return status; | ||
| } | ||
|
|
||
| public String getMessage() { | ||
| return message; | ||
| } | ||
|
|
||
| public Object getData() { | ||
| return data; | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.accumulo.core.cli; | ||
|
|
||
| import java.util.List; | ||
|
|
||
| /** | ||
| * Implemented by all command report classes that support both human-readable and computer readable | ||
| * outputs. | ||
| * <p> | ||
| * Json output is always wrapped in a {@link CommandOutputEnvelope} to provide a stable, versioned | ||
| * outer structure that scripts can depend on, regardless of which command is used. | ||
| * | ||
| * <p> | ||
| * Usage pattern is a command's execute() method: | ||
| * | ||
| * <pre> | ||
| * CommandReport report = buildReport(context, options); | ||
| * if (options.json()) { | ||
| * System.out.println(report.toEnvelopedJson("accumulo admin 'my-command'")); | ||
| * } else { | ||
| * report.formatLines().forEach(System.out::println); | ||
| * } | ||
| * </pre> | ||
| */ | ||
| public interface CommandReport { | ||
| List<String> formatLines(); | ||
|
|
||
| Object getData(); | ||
|
|
||
| default String toEnvelopedJson(String commandName) { | ||
| return CommandOutputEnvelope.of(commandName, getData()).toJson(); | ||
| } | ||
|
|
||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -59,9 +59,6 @@ public class ServiceStatus extends ServerKeywordExecutable<ServiceStatusCmdOpts> | |
|
|
||
| static class ServiceStatusCmdOpts extends ServerOpts { | ||
|
|
||
| @Parameter(names = "--json", description = "provide output in json format") | ||
| boolean json = false; | ||
|
|
||
| @Parameter(names = "--showHosts", | ||
| description = "provide a summary of service counts with host details") | ||
| boolean showHosts = false; | ||
|
|
@@ -106,17 +103,15 @@ public void execute(JCommander cl, ServiceStatusCmdOpts options) throws Exceptio | |
| ServiceStatusReport report = new ServiceStatusReport(services, options.showHosts); | ||
|
|
||
| if (options.json) { | ||
| System.out.println(report.toJson()); | ||
| System.out.println(report.toEnvelopedJson("accumulo admin service-status")); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It might make sense to add a method to ServerKeywordExecutable that returns the invoked command. This would make this more flexible if the command group or command name changes in the future. |
||
| } else { | ||
| StringBuilder sb = new StringBuilder(8192); | ||
| report.report(sb); | ||
| System.out.println(sb); | ||
| report.formatLines().forEach(System.out::println); | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * The manager paths in ZooKeeper are: {@code /accumulo/[IID]/managers/lock/zlock#[NUM]} with the | ||
| * lock data providing a service descriptor with host and port. | ||
| * op The manager paths in ZooKeeper are: {@code /accumulo/[IID]/managers/lock/zlock#[NUM]} with | ||
| * the lock data providing a service descriptor with host and port. | ||
| */ | ||
| @VisibleForTesting | ||
| StatusSummary getManagerStatus(ServerContext context) { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if the command output should be it's own top level element instead. For example,