Bench m4 macstudio max 128g#89
Open
zhaopengme wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds benchmark artifacts for an M4 Max Mac Studio (128GB) run of ds4-bench, extending the existing speed-bench/ hardware throughput dataset.
Changes:
- Added a new benchmark CSV with prefill/generation throughput across context sizes up to 65,536.
- Added a corresponding
_ts.svgthroughput plot for the new CSV.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| speed-bench/m4_macstudio_max_128g.csv | New throughput dataset (ctx vs prefill/gen t/s, kv-cache bytes). |
| speed-bench/m4_macstudio_max_128g_ts.svg | New SVG plot visualizing the dataset. |
Comments suppressed due to low confidence (1)
speed-bench/m4_macstudio_max_128g.csv:35
- The CSV ends with extra blank lines.
plot_speed.pyusescsv.DictReaderand will try to parse a blank record as a row (values becomeNone), which can raise when convertingctx_tokens/prefill_tps/gen_tps. Please remove the trailing empty rows so the file ends after the last numeric line (optionally with a single final newline).
65536,2048,210.47,128,22.34,926033292
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
m4 macstudio max 128g