add ROCm backend support#79
Open
alantsev wants to merge 1 commit into
Open
Conversation
b5a7126 to
6e4c3f8
Compare
|
@alantsev nice, tested on Ubuntu 26.04/Strix Halo with both the distro's ROCm 7.1 and AMD's 7.2.3 packages. |
|
Lot of these $2-3k machines out there. My friend has one. Glad you guys are doing the work to support this platform as well. Impressed that the community is going from Apple Metal -> CUDA -> ROCm support in just about a week. Someone is going to need to get a Strix machine in @antirez hands though before it will be merged in. I really think there needs to be some corporate level sponsorship on the hardware side for this project between Apple / Nvidia / AMD / Intel etc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add ROCm backend support
This PR adds ROCm support as a third GPU backend alongside the existing CUDA and Metal backends.
GPU_BACKEND=rocmwithhipcc, configurable viaROCM_PATHandROCM_ARCH. Existing CUDA and Metal builds are unchanged.ds4_cuda.cu— Now builds for both CUDA and ROCm from a single source via#ifdef __HIP_PLATFORM_AMD__, usingFULL_WARP_MASK/MASK_Tto handle the warp width difference.ds4_rocm.h(new) — Compatibility header mapping CUDA runtime / cuBLAS to HIP equivalents, plus AMD implementations of__vcmpne4,__vsub4,__dp4a.Build
Benchmarks — AMD Radeon 8060S (gfx1151), ROCm 6.x: