feat: add config setting to avoid subagents models overriding session model #7428
+14
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
d4rken
reviewed
Jan 9, 2026
fwang
force-pushed
the
feature/isolate-subagent-model
branch
from
97559c2 to
01dbf4d
Compare
Contributor
|
accidentally committed emails. srubbing from history and working w/ GH support to remove as much as possible. sorry about the confusion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a new config setting which, when enabled, stops models used in subagents and commands from bubbling up and overriding the main session model on completion.
I am unsure if this is a bug or intended behaviour. It seems like odd behaviour to me that running subagents would modify the parent session's model (and I'd very much not like to have to add a config setting) but I couldn't really be certain based on the comment above it.
How did you verify your code works?
Ran it locally and confirmed behaviour was fixed. Ran tests.
Fixes #7430