fix(session-ui): keep permission actions inside the dock prompt shell - #48536
Open
CannonRS wants to merge 1 commit into
Open
fix(session-ui): keep permission actions inside the dock prompt shell#48536CannonRS wants to merge 1 commit into
CannonRS wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #48532
Type of change
What does this PR do?
Adds an opt-in
footerInsideprop toDockPromptso permission actions can live inside the dock shell instead of a detached bottom tray, and tightens the permission footer layout for narrow widths.DockPromptrenders the footer in a separateDockTraybelow the shell. On narrow composer widths the permission buttons overflow and the footer looks detached from the content. The newfooterInsideprop keeps the actions inside the shell, wrapped and right-aligned; the default behaviour (footer in the tray) is unchanged, so question docks are not affected.SessionPermissionDockopts in viafooterInside, and the storybook story documents the permission variant.How did you verify your code works?
bun typecheck(tsgo) passes inpackages/appandpackages/session-ui.git diff --checkclean; no unrelated changes.Screenshots / recordings
n/a — will add a Storybook screenshot if a maintainer requests one.
Fork
Checklist