fix(app): handle session.error events in global sync - #48534
Open
CannonRS wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #48530
Type of change
What does this PR do?
The global sync reducer now handles
session.errorevents instead of ignoring them. When a session turn fails, the reducer resets the session status to idle and marks the last assistant message with an error andfinish: "error". A new optionalnotifyErrorcallback is threaded intoapplyDirectoryEvent; the server-sync layer uses it to show a toast with the error message (reusing the existingnotification.session.error.*i18n keys).How did you verify your code works?
bun typecheck(tsgo) passes inpackages/app.event-reducer.test.tspasses 17/17, including a new test asserting the status reset and assistant error marker onsession.error.git diff --checkclean; no unrelated changes.Screenshots / recordings
n/a (server/state behaviour; the toast is the only UI, using existing keys)
Fork
Checklist