fix(opencode): plain plugin spinner output outside TTY#37505
Open
mbaragiola wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #27908
Type of change
What does this PR do?
opencode plugin installused Clack's animated spinner even when stdout was not a TTY, so non-interactive shells printed spinner frames and ANSI junk.This change keeps the animated spinner on TTY, and writes plain one-line start/stop messages otherwise.
How did you verify your code works?
From
packages/opencode:bun test test/plugin/install.test.ts— 22 passbun typecheck— passIndependent read-only Codex review (
gpt-5.6-sol) returned PASS after applying a small test NIT forisTTY: undefinedandstop(..., code).Screenshots / recordings
N/A — CLI non-TTY behavior; covered by unit test.
Checklist