fix(snapshot): handle info/exclude write failure gracefully instead of orDie#37494
Open
mgajda wants to merge 1 commit into
Open
fix(snapshot): handle info/exclude write failure gracefully instead of orDie#37494mgajda wants to merge 1 commit into
mgajda wants to merge 1 commit into
Conversation
…f orDie Snapshot.sync writes info/exclude with Effect.orDie, so any EACCES (from UID mismatch in containerized setups or concurrent session writes) crashes SessionProcessor mid-conversation. The exclude file is advisory — a write failure should log a warning and continue. Closes anomalyco#37493
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #37493
Type of change
What does this PR do?
Snapshot.syncwrites toinfo/excludeinside the snapshot gitdir withEffect.orDie, so anyEACCES(from UID mismatch when the snapshot directory is shared between a container and the host, or from concurrent writes across sessions) crashes theSessionProcessormid-conversation with:Changes both write sites (
ensureDir+writeFileString) toEffect.catchwithEffect.logWarninginstead ofEffect.orDie. The exclude file is advisory — a write failure should log and continue, not kill the session.How did you verify your code works?
tsgo --noEmitpassespackages/opencodepassopencodefrom source confirms errors are logged as warnings instead of crashingScreenshots / recordings
N/A.
Checklist