Skip to content

test(cli): cover managed reconnect ensure-on-first-failure#37482

Closed
armancharan wants to merge 1 commit into
anomalyco:v2from
armancharan:fix/reconnect-ensure-first
Closed

test(cli): cover managed reconnect ensure-on-first-failure#37482
armancharan wants to merge 1 commit into
anomalyco:v2from
armancharan:fix/reconnect-ensure-first

Conversation

@armancharan

Copy link
Copy Markdown

Issue for this PR

Closes #36581

#36581

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

The reconnect delay itself already landed via the service lifecycle work. This adds the missing regression coverage from that issue: first failed reconnect runs ensure immediately, and passive reconnect reuses a healthy service from another version instead of replacing it.

Also exports ServerConnection.managedReconnect so that policy is testable without going through the full resolve path.

How did you verify your code works?

  • bun test test/server-connection.test.ts --timeout 30000
  • bun run typecheck in packages/cli

Screenshots / recordings

n/a

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

Made with Cursor

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@armancharan

Copy link
Copy Markdown
Author

Skipping — reconnect ensure already landed in #36895/#37133; not pursuing a separate test-seam follow-up.

@armancharan

Copy link
Copy Markdown
Author

Follow-up: the ensure-on-first-failure policy was already on v2; formal regression coverage that can close #36581 is in #37570.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant