fix(tui): make session scrollbar visible by default with better contrast#32195
fix(tui): make session scrollbar visible by default with better contrast#32195beiliya66677-wq wants to merge 1 commit into
Conversation
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
|
The following comment was made by an LLM, it may be inaccurate: Potential Duplicate Found:
Why it's related: This PR addresses a similar issue of making the session scrollbar visible and improving its appearance. Both PRs focus on improving scrollbar visibility and contrast in the session view. PR #27795 may have been a previous attempt or related work on the same problem. |
|
This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window. Feel free to open a new pull request that follows our guidelines. |
Problem
The right-side scrollbar in the session view is invisible by default on Windows Terminal (and other dark terminals). Two issues:
scrollbar_visibleKV signal defaults tofalse(set by PR fix(tui): restore hidden session scrollbar default #20947), so users must manually toggle it via Ctrl+P →Toggle session scrollbartheme.backgroundElement(#1a1a1a) ontheme.background(#0a0a0a) and the thumb usestheme.border(#262626) — both nearly indistinguishable on dark backgroundsChanges
packages/tui/src/routes/session/index.tsx:scrollbar_visibleKV default fromfalse→truebackgroundColorfromtheme.backgroundElement→theme.backgroundPanelfor subtle visual distinctionforegroundColorfromtheme.border→theme.textMutedfor a visible gray thumb across all themesCloses #25981