fix(app): refresh v2 tab titles#30335
Open
gzb1128 wants to merge 1 commit into
Open
Conversation
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Fixes #30329
Type of change
What does this PR do?
Fixes the v2 layout tab bar not refreshing when the model generates a session title.
Root cause:
mapArrayruns its mapper insideuntrack, so readingsession.titleinside the mapper creates no reactive subscription. When the store is later updated viareconcile(in thesession.updatedSSE handler), the mapped result stays stale.Fix: Extract tab enrichment into
createTitlebarTabsEnriched()(titlebar-tabs.ts). Instead of eagerly reading session data inside the untracked mapper, the helper stores the session accessor and exposestitleas a reactive getter:The
<For>render function now callstab.title()andtab.info()under a tracking scope, so updates propagate correctly.How did you verify your code works?
session.titleas a static snapshot, test asserts stale valuebun test --preload ./happydom.ts ./src/components/titlebar.test.tsfrompackages/app: 1 passbun typecheckfrompackages/app: no new errors (pre-existingmessage-timeline.tsxerror unrelated)git diff --check: cleanChecklist