Skip to content

feat(app): add desktop setting to toggle file changes display#30264

Open
anduimagui wants to merge 2 commits into
anomalyco:devfrom
anduimagui:feat/desktop-show-file-changes
Open

feat(app): add desktop setting to toggle file changes display#30264
anduimagui wants to merge 2 commits into
anomalyco:devfrom
anduimagui:feat/desktop-show-file-changes

Conversation

@anduimagui
Copy link
Copy Markdown

@anduimagui anduimagui commented Jun 1, 2026

Issue for this PR

Closes #9089 (desktop-specific)

Type of change

  • New feature

What does this PR do?

Adds a desktop-only setting to show or hide the "Changed file +N -M" diff summary in the session timeline. This gives users a cleaner chat view when they don't want the file-change accordion taking up vertical space.

Related work:

Changes:

  • packages/app/src/context/settings.tsx — adds showFileChanges boolean to general settings (default true)
  • packages/app/src/i18n/en.ts — adds English translation keys for the new setting
  • packages/app/src/components/settings-general.tsx — adds a desktop-gated <Switch> toggle in Settings > General
  • packages/app/src/pages/session/message-timeline.tsx — wraps DiffSummary timeline rows with a reactive <Show> so they hide/show instantly when the setting changes

Why it works:
The toggle uses the existing settings.general persistence layer (already used by showReasoningSummaries, showSessionProgressBar, etc.). In the timeline, <Show when={...}> creates a SolidJS reactive subscription, so the rows update in real time without waiting for a new message or re-render.

How did you verify your code works?

  • bun typecheck in packages/app passes (pre-existing unrelated errors in stats-server/stats-core)
  • No new tests added — follows the existing settings pattern used by other boolean toggles

Screenshots / recordings

Not included.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@anduimagui anduimagui requested a review from adamdotdevin as a code owner June 1, 2026 17:09
@github-actions github-actions Bot added needs:compliance This means the issue will auto-close after 2 hours. and removed needs:compliance This means the issue will auto-close after 2 hours. labels Jun 1, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 1, 2026

Thanks for updating your PR! It now meets our contributing guidelines. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: TUI option for minimal/collapsed diff display

1 participant