feat(app): add desktop setting to toggle file changes display#30264
Open
anduimagui wants to merge 2 commits into
Open
feat(app): add desktop setting to toggle file changes display#30264anduimagui wants to merge 2 commits into
anduimagui wants to merge 2 commits into
Conversation
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #9089 (desktop-specific)
Type of change
What does this PR do?
Adds a desktop-only setting to show or hide the "Changed file +N -M" diff summary in the session timeline. This gives users a cleaner chat view when they don't want the file-change accordion taking up vertical space.
Related work:
thdxr, with strong community support.feat(tui): add minimal diff display mode) by LIHUA919 that addedtui.diff_displayconfig. It was closed due to staleness after 60 days without maintainer review.fix(desktop): collapse full-context git diffs(open). This is related but different scope — it fixes rendering of full-context generated patches in the Git Changes sidebar, not the timeline header.Changes:
packages/app/src/context/settings.tsx— addsshowFileChangesboolean togeneralsettings (defaulttrue)packages/app/src/i18n/en.ts— adds English translation keys for the new settingpackages/app/src/components/settings-general.tsx— adds a desktop-gated<Switch>toggle in Settings > Generalpackages/app/src/pages/session/message-timeline.tsx— wrapsDiffSummarytimeline rows with a reactive<Show>so they hide/show instantly when the setting changesWhy it works:
The toggle uses the existing
settings.generalpersistence layer (already used byshowReasoningSummaries,showSessionProgressBar, etc.). In the timeline,<Show when={...}>creates a SolidJS reactive subscription, so the rows update in real time without waiting for a new message or re-render.How did you verify your code works?
bun typecheckinpackages/apppasses (pre-existing unrelated errors instats-server/stats-core)Screenshots / recordings
Not included.
Checklist