fix(app): allow Load More to refetch when trimmed session cache is insufficient#23033
Open
ztexydt-cqh wants to merge 1 commit intoanomalyco:devfrom
Open
fix(app): allow Load More to refetch when trimmed session cache is insufficient#23033ztexydt-cqh wants to merge 1 commit intoanomalyco:devfrom
ztexydt-cqh wants to merge 1 commit intoanomalyco:devfrom
Conversation
…sufficient (closes anomalyco#23026)
github-actions
bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #23026
Type of change
What does this PR do?
When there are many sessions, clicking "Load More" often does nothing because
loadSessionsreturns early whenmeta.limit >= store.limit, even though the store only keeps a trimmed subset of sessions. This change adds a root-count check so the function only skips the API call when we already have enough root sessions loaded or when there are no more sessions on the server.How did you verify your code works?
Reviewed the logic against the frontend state flow and confirmed the diff is minimal and safe.
Screenshots / recordings
N/A
Checklist