Skip to content

refactor: remove ambient instance reads from lsp#23023

Open
kitlangton wants to merge 2 commits intodevfrom
kit/lsp-instance-context
Open

refactor: remove ambient instance reads from lsp#23023
kitlangton wants to merge 2 commits intodevfrom
kit/lsp-instance-context

Conversation

@kitlangton
Copy link
Copy Markdown
Contributor

Summary

  • thread InstanceState context through LSP server root and spawn resolution instead of reading ambient Instance.*
  • resolve LSP client relative paths from the instance directory passed in by the caller
  • keep the change scoped to the three LSP files without changing service boundaries

Testing

  • cd packages/opencode && bun typecheck (fails in this worktree because the script resolves to tsgo --noEmit and tsgo is not installed locally)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant