Skip to content

fix(electron): quit app on window-all-closed to kill sidecar on macOS #23018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vaishnavmhetre wants to merge 1 commit into
base: dev
Choose a base branch
from
+8 −0
Open

fix(electron): quit app on window-all-closed to kill sidecar on macOS #23018

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/desktop-electron/src/main/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,14 @@ function setupApp() {
killSidecar()
})

// On macOS, closing all windows does not quit the app by default —
// the process stays alive in the Dock with the sidecar still running.
// Explicitly quit so the sidecar is cleaned up via before-quit/will-quit.
app.on("window-all-closed", () => {
killSidecar()
app.quit()
})

for (const signal of ["SIGINT", "SIGTERM"] as const) {
process.on(signal, () => {
killSidecar()
Expand Down
Loading