Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking my latest work into small PRs. This one adds a new context that code that use to get the
workspaceIDI didn't want to introduce a new concept initially, and tried to add a
workspaceIDgetter toInstanceinstead. That turned out to cause all sorts of confusion though: sometimes onlydirectoryis available and no workspace id (that won't be the case long-term, but we will need a phase of migration), and the other way around too. In particular, it caused a lot of confusion due to caching of the context value internally; do we cache based on directory or workspace id? It should be workspace id, but sometimes that isn't availablePulling it out into a new
WorkspaceContextsimplified everything. This is purely internal and publicly people won't be dealing with both instances and workspaces.Similar to
directory, this adds a new way to "route" requests: you can specify aworkspaceurl param or use thex-opencode-workspaceheader to scope your action to a specific workspace. Eventually, everything will be a workspace, even your default local repo.I have more work which builds on this to rework the router in
control-planeto leverage it and will open more once this lands.