Skip to content

fix(volcengine-coding-plan): add glm-5.3-flash and kimi-k3 - #6831

Merged
rekram1-node merged 3 commits into
anomalyco:devfrom
cifangyiquan:fix/volcengine-coding-plan-missing-models
Sep 11, 2026
Merged

fix(volcengine-coding-plan): add glm-5.3-flash and kimi-k3#6831
rekram1-node merged 3 commits into
anomalyco:devfrom
cifangyiquan:fix/volcengine-coding-plan-missing-models

Conversation

@cifangyiquan

Copy link
Copy Markdown
Contributor

Summary

The official model configuration list for Coding Plan (https://www.volcengine.com/docs/82379/1928261, "支持配置的 Model Name") currently includes 10 models; this provider modeled only 8. Adding the two missing ones:

  • glm-5.3-flash — listed explicitly alongside glm-5.3 (glm-latest)
  • kimi-k3 — listed alongside kimi-k2.7-code

Both are zero-cost subscription entitlements, matching the existing entries. glm-5.3-flash mirrors the effort levels already declared in providers/zai-coding-plan/models/glm-5.3-flash.toml; for kimi-k3 I kept reasoning_options = [] like the kimi-k2.7-code relay entry and noted that endpoint-level effort behavior wasn't measured — happy to adjust if maintainers have observations.

Source accessed 2026-09-11.

🤖 Generated with Claude Code

The model list in https://www.volcengine.com/docs/82379/1928261 (Model Name
configuration) includes glm-5.3-flash and kimi-k3, but the provider only
modeled glm-5.3 and kimi-k2.7-code. Both are zero-cost subscription
entitlements like the other eight entries.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

Action items

  • [high] [violation] providers/volcengine-coding-plan/models/kimi-k3.toml:8 - Check: Relay reasoning_options must match lab/same-surface peers, not [] from uncertainty. Why: Lab providers/moonshotai/models/kimi-k3.toml and peers (e.g. OpenRouter, kimi-for-coding) expose toggle + effort low/high/max. This host is a multi-model relay; AGENTS.md / the reasoning audit skill forbid [] when controls exist upstream and you only skipped measuring this endpoint. Copying kimi-k2.7-code is invalid — that entry is empty only after measured no-effect on that model. Action: Author lab/peer baseline (toggle + effort ["low","high","max"]) with a leading wire comment for this host (thinking.type, effort field), or measure on /api/coding/v3 and keep [] only with affirmative no-control evidence like the sibling files.

Per review: relay reasoning_options must not be [] from unmeasured
uncertainty. Mirrors moonshotai/kimi-k3 and kimi-for-coding (toggle +
effort low/high/max) with the /api/coding/v3 wire fields documented;
endpoints-specific level behavior flagged as unmeasured.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@cifangyiquan

Copy link
Copy Markdown
Contributor Author

Good catch — fixed in the latest push. reasoning_options now mirrors the lab (providers/moonshotai/models/kimi-k3.toml) and the kimi-for-coding relay baseline:

[[reasoning_options]]
type = "toggle"

[[reasoning_options]]
type = "effort"
values = ["low", "high", "max"]

with the /api/coding/v3 wire fields documented in the header (thinking.type = enabled|disabled|adaptive, output_config.effort = low|high|max). I did not measure endpoint-specific level behavior, so the comment notes the baseline is inherited and should be trimmed if probing shows levels collapse as they do on kimi-k2.7-code.

@github-actions

Copy link
Copy Markdown
Contributor

Action items

  • [medium] [violation] providers/volcengine-coding-plan/models/kimi-k3.toml:7 - Check: Toggle/effort wire comments must document this host’s real request fields. Why: The leading comment claims POST /api/coding/v3/chat/completions accepts output_config.effort and thinking.type=adaptive, but this provider’s OpenAI coding path uses reasoning_effort (and typically thinking.type enabled|disabled); output_config.effort is the Anthropic Messages / Moonshot–kimi-for-coding surface, not the chat-completions path in provider.toml. Action: Rewrite the wire comment for volcengine coding-plan (e.g. thinking.type + reasoning_effort on /api/coding/v3/chat/completions, and Anthropic output_config.effort only if documenting that path separately). Keep the lab/peer option set (toggle + low/high/max) unless endpoint probing shows otherwise.

reasoning_effort (not output_config.effort) on the OpenAI chat path;
thinking.type is enabled|disabled without the lab-only adaptive value.
output_config.effort noted for the separate Anthropic path. Option set
unchanged (toggle + low/high/max).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@cifangyiquan

Copy link
Copy Markdown
Contributor Author

Fixed — the wire comment now documents this provider's real fields per provider.toml:

POST /api/coding/v3/chat/completions takes
thinking.type = enabled|disabled plus reasoning_effort = low|high|max

with notes that adaptive is the Moonshot lab surface (not accepted on this relay) and that output_config.effort belongs to the separate Anthropic /api/coding/v1/messages path. The declared option set stays toggle + low/high/max; unmeasured endpoint behavior remains explicitly flagged.

@github-actions

Copy link
Copy Markdown
Contributor

No actionable findings.

@github-actions github-actions Bot added the reviewer: ready Automated review found no actionable items label Sep 11, 2026
@rekram1-node
rekram1-node merged commit 0ba0c45 into anomalyco:dev Sep 11, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

reviewer: ready Automated review found no actionable items

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants