[Multiple-Profile]fix: external directory not created for profile#20752
Open
criticalAY wants to merge 2 commits intoankidroid:mainfrom
Open
[Multiple-Profile]fix: external directory not created for profile#20752criticalAY wants to merge 2 commits intoankidroid:mainfrom
criticalAY wants to merge 2 commits intoankidroid:mainfrom
Conversation
Member
david-allison
left a comment
There was a problem hiding this comment.
This seems incorrect, I'm not sure I understand the logic
4407f00 to
4c32e33
Compare
david-allison
requested changes
Apr 18, 2026
4c32e33 to
565f336
Compare
565f336 to
11d5095
Compare
Member
david-allison
left a comment
There was a problem hiding this comment.
Given the complexity here, let's simplify it further
11d5095 to
379c741
Compare
david-allison
requested changes
Apr 23, 2026
Member
david-allison
left a comment
There was a problem hiding this comment.
Functionality is awesome. 1 docs change due to the complexity
379c741 to
61bda96
Compare
david-allison
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
Fixes a VERY BIG BLUNDER that I did earlier, I overlooked external dir. but thanks to @david-allison I figured this one, apart from deletion the addition logic was also missing
Fixes
Approach
See commit
How Has This Been Tested?
Unit test to verify that directory was created
Learning (optional, can help others)
Always doc first
Checklist
Please, go through these checks before submitting the PR.