Skip to content

[Multiple-Profile]fix: external directory not created for profile#20752

Open
criticalAY wants to merge 2 commits intoankidroid:mainfrom
criticalAY:mp/fix-external-dir
Open

[Multiple-Profile]fix: external directory not created for profile#20752
criticalAY wants to merge 2 commits intoankidroid:mainfrom
criticalAY:mp/fix-external-dir

Conversation

@criticalAY
Copy link
Copy Markdown
Contributor

Purpose / Description

Fixes a VERY BIG BLUNDER that I did earlier, I overlooked external dir. but thanks to @david-allison I figured this one, apart from deletion the addition logic was also missing

Fixes

Approach

See commit

How Has This Been Tested?

Unit test to verify that directory was created

Learning (optional, can help others)

Always doc first

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@criticalAY criticalAY changed the title [Multi-Profile]fix: external directory not created for profile [Multiple-Profile]fix: external directory not created for profile Apr 15, 2026
Copy link
Copy Markdown
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems incorrect, I'm not sure I understand the logic

Comment thread AnkiDroid/src/main/java/com/ichi2/anki/multiprofile/ProfileContextWrapper.kt Outdated
@criticalAY criticalAY force-pushed the mp/fix-external-dir branch 3 times, most recently from 4407f00 to 4c32e33 Compare April 17, 2026 22:13
Comment thread AnkiDroid/src/main/java/com/ichi2/anki/multiprofile/ProfileManager.kt Outdated
@criticalAY criticalAY force-pushed the mp/fix-external-dir branch from 4c32e33 to 565f336 Compare April 18, 2026 21:18
Copy link
Copy Markdown
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the complexity here, let's simplify it further

Comment thread AnkiDroid/src/main/java/com/ichi2/anki/multiprofile/ProfileManager.kt Outdated
@criticalAY criticalAY force-pushed the mp/fix-external-dir branch from 11d5095 to 379c741 Compare April 21, 2026 10:15
Copy link
Copy Markdown
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality is awesome. 1 docs change due to the complexity

Comment thread AnkiDroid/src/main/java/com/ichi2/anki/CollectionHelper.kt Outdated
@david-allison david-allison added Needs Author Reply Waiting for a reply from the original author Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Apr 23, 2026
@criticalAY criticalAY force-pushed the mp/fix-external-dir branch from 379c741 to 61bda96 Compare April 23, 2026 13:51
@criticalAY criticalAY removed the Needs Author Reply Waiting for a reply from the original author label Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Second Approval Has one approval, one more approval to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants