fix: load video tags via relative src instead of file:// URI#20732
Open
Ayush-Patel-56 wants to merge 1 commit intoankidroid:mainfrom
Open
fix: load video tags via relative src instead of file:// URI#20732Ayush-Patel-56 wants to merge 1 commit intoankidroid:mainfrom
Ayush-Patel-56 wants to merge 1 commit intoankidroid:mainfrom
Conversation
Member
|
Please test it with some special chars that probably should be encoded: |
6cd720c to
a52d321
Compare
Contributor
Author
|
Thanks for pointing it out, I've updated the PR with URI encoding for the |
BrayanDSO
reviewed
Apr 22, 2026
a52d321 to
fb9bc15
Compare
Member
|
Asked for a |
Contributor
Author
|
sent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
Fixes an issue where video files in
[sound:]tags fail to load due to CORS policies blockingfile:///paths when the WebView base URL ishttp://127.0.0.1.Fixes
Fixes #20668
Approach
Replaced the
file:///URI generation for<video src="...">with just the raw relative filename.The
ViewerResourceHandlerwill natively intercept these requests and respond withRangeheaders over HTTP. This cleanly solves the cross-origin bug without sacrificing video seeking capabilities or needing an external activity.How Has This Been Tested?
Built locally. Tested on a flashcard with an embedded video file to verify that the inline
<video>tag loads the player and successfully plays back with functioning playback/scrubbing controls.Video:
untitled.mp4
Checklist