Reorganize platform detection and support Alpine amd64#80
Closed
trekdemo wants to merge 2 commits intoankane:masterfrom
Closed
Reorganize platform detection and support Alpine amd64#80trekdemo wants to merge 2 commits intoankane:masterfrom
trekdemo wants to merge 2 commits intoankane:masterfrom
Conversation
Replace the if/elsif chain for supported OS/distro resolution with a declarative platforms hash, making it easy to see at a glance which operating systems and distributions are supported: - macOS (x86_64, ARM) - Debian 11, 12 (amd64) - Ubuntu 20.04, 22.04, 24.04 (amd64) - Arch Linux (amd64) Extract OS detection into a dedicated `detect_os` method that returns a consistent [os, version, arm?] tuple used as the lookup key. Look up nil version as a wild-card value When a binaries support multiple versions of the OS, use `nil` as the value and during lookup. This also means that the binaries are not version specific on the given OS.
trekdemo
force-pushed
the
organize-supported-distros
branch
from
acab1ca to
3735ea4
Compare
trekdemo
changed the title
Owner
|
Hi @trekdemo, thanks for the PR. It looks like the build uses |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the if/elsif chain for supported OS/distro resolution with a declarative platforms hash, making it easy to see at a glance which operating systems and distributions are supported:
The second commit, adds support for Alpine on amd64.
I'm really happy I found your gem because it made it easy to use or-tools in my Rails app. Small hiccup, the app runs in Docker on Alpine Linux. There's official support for amd64, and I'm working on the arm64 support. I'd like to add support for them in the near future.