Fix typings for several ElementArrayFinder methods#4671
Fix typings for several ElementArrayFinder methods#4671inad9300 wants to merge 1 commit intoangular:masterfrom inad9300:master
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
1 similar comment
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I've signed the agreement thing... Am I now an official non-paid Google employee? |
|
CLAs look good, thanks! |
1 similar comment
|
CLAs look good, thanks! |
| */ | ||
| filter( | ||
| filterFn: (element: ElementFinder, index?: number) => boolean | | ||
| filterFn: (element: ElementFinder, index: number) => boolean | |
There was a problem hiding this comment.
Why does the index parameter should be required?
There was a problem hiding this comment.
Removing the question mark does not mean that you are forced to accept index as a parameter in your callback. This is the whole point of #4634.
Some of the callback functions had an incorrect
?for their arguments.Done for #4634.