Add Sauce Labs Mobile Testing(Test Object) and Kobiton capabilities to driver providers#4577
Conversation
Changed testobject.key to testobject_api_key so capabilities file reads it correctly
|
Test Object was acquired by Sauce Labs and is what Sauce Labs now uses for their Real Device Testing. These changes allow a user to interact with Test Object devices. |
lt-bstevens
changed the title
lt-bstevens
changed the title
…dd-testobject-driver-provider
|
Can you please take a look at this one, it makes live easier for people who want to use the Mobile part of Sauce Labs |
|
@wswebcreation @lt-bstevens |
Many Sauce Labs customers are looking to test against the Real Device Cloud available through Test Object for mobile automation. These changes add that ability and will pull those credentials in to be used for remote connection, if credentials are present.
…dd-testobject-driver-provider
…dd-testobject-driver-provider
…rovider 1. Add testObject to driverProviders 2. Add testObject items to cli, config and index 3. Add instructions for using testObject to server-setup
…er' into add-testobject-driver-provider
|
@qiyigg @wswebcreation @cnishina , I've added a new commit that follows the standard from the Contributing markdown file. It's in commit 3b2646c. |
|
Hi @lt-bstevens I'm not allowed to merge because I can't create a new version and push to NPM. This needs to be done by the core-team members. @qiyigg and @cnishina can do that. @cnishina is I think the best person to judge the code and give the final approval on it. As far as I can see I don't see any problems. |
|
@lt-bstevens @wswebcreation We can wait another week to get more review for this PR. If no other change is needed after this week, I can merge it directly. make sense? |
|
@lt-bstevens and @qiyigg I've talked to Craig and he'll check it this weekend, I'll try to remember him ;-) |
|
OK, thanks! |
1. Add testObject and kobiton to driverProviders 2. Add testObject and kobiton items to cli, config and index 3. Add instructions for using testObject and kobiton to server-setup
1. Add testObject and kobiton to driverProviders 2. Add testObject and kobiton items to cli, config and index 3. Add instructions for using testObject and kobiton to server-setup
lt-bstevens
changed the title
…rovider Fixed formatting in kobiton and config files
…rovider 1. Add testObject to driverProviders 2. Add testObject items to cli, config and index 3. Add instructions for using testObject to server-setup
|
I've added Kobiton as another driver provider as I've been working with their mobile automation offering as well. I've updated the commit message to reflect the addition in this commit a7655e1, as well as the PR. The only difference between the files is variable names and the selenium address is a little different for Kobiton. |
|
Just checking on the status of this. It doesn't look like @cnishina was able to take a look at it last weekend. Thanks! |
|
True, I also forgot, sorry, will ping him again |
|
Thanks @wswebcreation ! |
|
Happy New Year @wswebcreation @qiyigg and @cnishina ! It looks like this hasn't been reviewed yet by Craig. Any chance you can remind him again now that the holiday season is over? Thanks! |
|
@wswebcreation just checking in on this one again. Any chance you could reach out again? Thanks! |
|
I don't mind merging this PR if @cnishina doesn't have time to review it. It looks not harmful. |
|
@qiyigg that would be great. I'm fine with continuing to work on it if bugs do pop up in the future. They'd likely impact my work anyways so I'd be working on them anyways. Thanks! |
|
@wswebcreation @lt-bstevens |
|
@qiyigg, that's fine with me. When will you make a new release? |
|
@wswebcreation maybe at the end of month if no urgent need. I planed to make a release every one or two months |
|
@qiyigg Ok But then I would advise to only merge before a release instead of merge during a month. Otherwise people who try to debug on a git source that has not been released (except for doc changes), or am I seeing this wrong/you have different thoughts about it? |
|
@wswebcreation |
|
@qiyigg @wswebcreation we use npm and a package file to get protractor into our project. So we won't have access to the changes made until the next release? Just trying to determine when we can access the code change. Thanks! |
|
yes, this change only exists in master branch right now and you do need a new release to have all the new changes. |
|
If the release can be pushed up at all it would be greatly appreciated. We're currently unable to test mobile automation with automated builds via bamboo and have been delayed in our mobile efforts due to the project not having these changes. We'd hoped the changes would have been ready before the end of the year (2017) and are expected to show our findings and pick a mobile automation tool by the end of the month. If you can move the release up sooner it would be extremely helpful for us to hit our deadlines. |
|
@lt-bstevens I don't think I can do it this week, but I could try to make it next week, is that fine for you? |
|
@qiyigg I completely understand if you can't do this week. Next week would be awesome! Thank you! |
|
You are right, it won't affect it. On the other hand, this remark of @lt-bstevens
was my main reason. I think 95% (or even more) uses the NPM version, so waiting between 3-6 weeks on PR's / bugs being released to a new version on NPM is in my opinion, and from a user perspective, a bit to long. A lot of people rely on Protractor for their build and testprocess so this will affect them in the speed to release their products (or create hacks to test specific situations). I'm not trying to give you more work, because I think you are doing a lot already, but I'm also trying to approach it from a user perspective. With around 50.000-70.000 downloads a day I think I can speak for a lot of users ;-) Grtz Wim |
|
@qiyigg @wswebcreation checking in on the status of the new release. When we last spoke you thought this week was a possibility, is that still the case? If so, do you know when you'd be doing that? Thanks! |
|
I will do it within this week. I plan to start it today, ideally I can make the release tomorrow. |
|
@qiyigg awesome! Thank you! |
|
@qiyigg any update on when the release will be? Thanks! |
|
@lt-bstevens I tried to make a release last week but found the integration test in circleCI was broken. I looked into it for a while and then switched to other jobs. I will have some time to investigate it today, hopefully it can be fixed today and I can make the release. |
|
Thanks for the update @qiyigg ! |
4 participants
Sauce Labs and Kobtion customers are looking to test against the Real Device Cloud available through Test Object and Kobtion. These changes add that ability and will pull those credentials in to be used for remote connection, if credentials are present.
*Added testObject and kobtion as driver providers
*Changed configuration files to retrieve testObject data, if present. If not and kobiton data is present, kobiton will be used.