Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

fix(element): correct typing of method map()#4549

Open
RomkeVdMeulen wants to merge 3 commits intoangular:masterfrom
RomkeVdMeulen:patch-1
Open

fix(element): correct typing of method map()#4549
RomkeVdMeulen wants to merge 3 commits intoangular:masterfrom
RomkeVdMeulen:patch-1

Conversation

@RomkeVdMeulen
Copy link
Copy Markdown

The elementFinder and index arguments of the mapping function passed to ElementArrayFinder.map() will never be undefined.

Fixes #4548

The elementFinder and index arguments of the mapping function passed to ElementArrayFinder.map() will never be undefined.

Fixes angular#4548
@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

1 similar comment
@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@RomkeVdMeulen
Copy link
Copy Markdown
Author

I signed it!

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

Broadening the scope of the return type to any is not necessary: any
return type will be supported by T.

Fixes angular#4551.
@qiyigg qiyigg requested a review from sjelin January 18, 2018 18:46
@JacobPatenaude-AI
Copy link
Copy Markdown

I'm not sure if this PR is still active, but should each also have its typings changed?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants