fix(element): correct typing of method map()#4549
fix(element): correct typing of method map()#4549RomkeVdMeulen wants to merge 3 commits intoangular:masterfrom
Conversation
The elementFinder and index arguments of the mapping function passed to ElementArrayFinder.map() will never be undefined. Fixes angular#4548
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
1 similar comment
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
CLAs look good, thanks! |
1 similar comment
|
CLAs look good, thanks! |
Broadening the scope of the return type to any is not necessary: any return type will be supported by T. Fixes angular#4551.
|
I'm not sure if this PR is still active, but should each also have its typings changed? |
The elementFinder and index arguments of the mapping function passed to ElementArrayFinder.map() will never be undefined.
Fixes #4548