fix(element): prevent concurrent map functions#4508
fix(element): prevent concurrent map functions#4508wvanderdeijl wants to merge 2 commits intoangular:masterfrom
Conversation
prevents running multiple concurrent webdriver commands when selenium promise manager is disabled
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
1 similar comment
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
CLAs look good, thanks! |
1 similar comment
|
CLAs look good, thanks! |
|
Hi - Can you write a test for this? |
|
@vikerman tests have been added. I've added one test that simply does a .map over a lot of elements. It has to be a large number of elements as it is a race (concurrency) issue. With this many elements it consistently fails with ChromeDriver on MacOS. |
|
Waiting for this fix to be merged =) |
|
Hello guys Any progress with this pull request? It's really painful to get |
|
I'm also waiting on this fix. Currently getting this error when using filter(). |
|
Any progress on this? |
|
+1 is it possible to get this in? |
|
+1 get errors with |
|
@wvanderdeijl Could you fetch the latest master branch and rebase your PR and check whether circleCI can pass now? Thanks! |
|
Any progress on this? |
prevents running multiple concurrent webdriver commands when selenium promise manager is disabled
fixes #4507