Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

fix(frameworks): make mocha globals available on onPrepare, similarly to how it works on other frameworks#4484

Open
ronami wants to merge 1 commit intoangular:masterfrom
ronami:master
Open

fix(frameworks): make mocha globals available on onPrepare, similarly to how it works on other frameworks#4484
ronami wants to merge 1 commit intoangular:masterfrom
ronami:master

Conversation

@ronami
Copy link
Copy Markdown

@ronami ronami commented Sep 13, 2017

Mocha globals are not available when onPrepare is run. This prevents proper setup using before, after or other Mocha globals.

Mocha's loadFiles() method makes its globals available if any test files have been added. Calling loadFiles() before adding any test files is noop (see here, and here).

This change adds the test files before calling mocha.loadFiles() so it actually loads files, and thus, making these globals available during onPrepare and matching the way mocha works to other frameworks.

This change is backward compatible and matches the way other frameworks work within Protractor.

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

1 similar comment
@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@ronami
Copy link
Copy Markdown
Author

ronami commented Sep 17, 2017

I signed it!

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants