Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

fix(blockingproxy): don't pass "--inspect" to the child process #4398

Open
wncm wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(blockingproxy): don't pass "--inspect" to the child process #4398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/bpRunner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,11 @@ export class BlockingProxyRunner {
if (this.config.highlightDelay) {
args.push('--highlightDelay', this.config.highlightDelay.toString());
}
this.bpProcess = fork(BP_PATH, args, {silent: true});

// Prevent BP process from trying to allocate the same port for inspector as the main process
let execArgv = process.execArgv.filter(arg => !/^(--inspect|--debug)(-brk)?(?!=0)/.test(arg));

this.bpProcess = fork(BP_PATH, args, {execArgv, silent: true});
logger.info('Starting BlockingProxy with args: ' + args.toString());
this.bpProcess
.on('message',
Expand Down
1 change: 1 addition & 0 deletions scripts/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ var passingTests = [
'node built/cli.js spec/restartBrowserBetweenTestsConf.js',
'node built/cli.js spec/driverProviderLocalConf.js',
'node built/cli.js spec/driverProviderLocalConf.js --useBlockingProxy',
'node --inspect built/cli.js spec/driverProviderLocalConf.js --useBlockingProxy',
'node built/cli.js spec/getCapabilitiesConf.js',
'node built/cli.js spec/controlLockConf.js',
'node built/cli.js spec/customFramework.js',
Expand Down