feat(saucelabs): Removed unnecessary username and accesskey from cap…#4285
feat(saucelabs): Removed unnecessary username and accesskey from cap…#4285sirwalt wants to merge 1 commit intoangular:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
1 similar comment
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
c6f89cf to
66002cd
Compare
…abilities and fixed build in capabilities to be only overwritten under condition
|
CLAs look good, thanks! |
1 similar comment
|
CLAs look good, thanks! |
…abilities and fixed build in capabilities to be only overwritten under condition
There was no actual reason to set username and accesskey as capabilities on the selenium driver. Sourcelabs doesn't require those.
Overwriting the build capability from the sauceBuild config parameter seams to be logical since it couldn't differ between multiple capabilities within a single build, but it is unexpected. Without any check if the value of souceBuild is defined, there is no chance to set it within capabilities as someone is used to do.