Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

feat(saucelabs): Removed unnecessary username and accesskey from cap…#4285

Open
sirwalt wants to merge 1 commit intoangular:masterfrom
sirwalt:master
Open

feat(saucelabs): Removed unnecessary username and accesskey from cap…#4285
sirwalt wants to merge 1 commit intoangular:masterfrom
sirwalt:master

Conversation

@sirwalt
Copy link
Copy Markdown

@sirwalt sirwalt commented May 13, 2017

…abilities and fixed build in capabilities to be only overwritten under condition

There was no actual reason to set username and accesskey as capabilities on the selenium driver. Sourcelabs doesn't require those.

Overwriting the build capability from the sauceBuild config parameter seams to be logical since it couldn't differ between multiple capabilities within a single build, but it is unexpected. Without any check if the value of souceBuild is defined, there is no chance to set it within capabilities as someone is used to do.

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@sirwalt sirwalt force-pushed the master branch 2 times, most recently from c6f89cf to 66002cd Compare May 13, 2017 01:38
…abilities and fixed build in capabilities to be only overwritten under condition
@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants