This repository was archived by the owner on Jul 29, 2024. It is now read-only.
fix(firefox): Fix legacy FirefoxDriver support#4114
Open
thompsnm wants to merge 1 commit intoangular:masterfrom
Open
fix(firefox): Fix legacy FirefoxDriver support#4114thompsnm wants to merge 1 commit intoangular:masterfrom
thompsnm wants to merge 1 commit intoangular:masterfrom
Conversation
heathkit
approved these changes
May 5, 2017
Contributor
|
Sorry this has been sitting so long! If you rebase I'll get it in, thanks. |
Conditionally instantiate the firefoxService. The legacy FirefoxDriver fails to start if it is passed an executor.
thompsnm
force-pushed
the
fix-legacy-firefoxdriver-support
branch
from
a9db833 to
ca0208b
Compare
Author
|
Ha, looks like I was much worse about letting this PR sit! I'm cleaning up old PRs I still have open and noticed this. I have completed the rebase if you would like to still merge this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conditionally instantiate the firefoxService. The legacy FirefoxDriver fails to start if it is passed an executor.