build: sync-all-modules.sh now explicitly uses the local Bazel bina…#3532
Merged
alan-agius4 merged 1 commit intoangular:mainfrom Mar 13, 2026
Merged
build: sync-all-modules.sh now explicitly uses the local Bazel bina…#3532alan-agius4 merged 1 commit intoangular:mainfrom
sync-all-modules.sh now explicitly uses the local Bazel bina…#3532alan-agius4 merged 1 commit intoangular:mainfrom
Conversation
angular-robot
bot
added
the
area: build & ci
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates sync-all-modules.sh to explicitly use the local Bazel binary from node_modules and to run pnpm commands silently. The changes correctly reference the Bazel binary via a BAZEL environment variable. My feedback includes a suggestion to make the script more robust by reliably determining the project's root directory, ensuring it works correctly regardless of where it's invoked from.
…ry from `node_modules` and runs `pnpm` commands silently
crisbeto
approved these changes
Mar 13, 2026
Contributor
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ry from
node_modulesand runspnpmcommands silently