fix(aria/menu): expose expanded state as a model and allow shared menu#33320
Draft
ok7sai wants to merge 1 commit into
Draft
fix(aria/menu): expose expanded state as a model and allow shared menu#33320ok7sai wants to merge 1 commit into
ok7sai wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hold off this PR for the stable release. This requires more testing and thought out on the directive bindings...
--
This provides the minimal support for sharing one single menu/submenu across multiple menu triggers/items which fixes #32782 and #32731. For usage please refer to the example code.
However, because
ngMenuholds the list navigation information, reusing the same menu across triggers might end up having the wrong initial focus item. Although most of the time enter/arrow down should still go to the first focusable menu item.The code example is also tested with screen readers and overall seems to work fine.