Skip to content

fix(multiple): make more public APIs readonly #33071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
crisbeto merged 1 commit into from
Apr 12, 2026
Merged

fix(multiple): make more public APIs readonly #33071

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions goldens/aria/combobox/index.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,14 @@ export class Combobox<V> {
readonly disabled: _angular_core.InputSignalWithTransform<boolean, unknown>;
readonly element: HTMLElement;
readonly expanded: _angular_core.Signal<boolean>;
filterMode: _angular_core.InputSignal<"manual" | "auto-select" | "highlight">;
readonly filterMode: _angular_core.InputSignal<"manual" | "auto-select" | "highlight">;
readonly firstMatch: _angular_core.InputSignal<V | undefined>;
readonly inputElement: _angular_core.Signal<HTMLInputElement | undefined>;
open(): void;
readonly _pattern: ComboboxPattern<any, V>;
readonly popup: _angular_core.Signal<ComboboxPopup<V> | undefined>;
readonly readonly: _angular_core.InputSignalWithTransform<boolean, unknown>;
protected textDirection: _angular_core.Signal<_angular_cdk_bidi.Direction>;
protected readonly textDirection: _angular_core.Signal<_angular_cdk_bidi.Direction>;
// (undocumented)
static ɵdir: _angular_core.ɵɵDirectiveDeclaration<Combobox<any>, "[ngCombobox]", ["ngCombobox"], { "filterMode": { "alias": "filterMode"; "required": false; "isSignal": true; }; "disabled": { "alias": "disabled"; "required": false; "isSignal": true; }; "readonly": { "alias": "readonly"; "required": false; "isSignal": true; }; "firstMatch": { "alias": "firstMatch"; "required": false; "isSignal": true; }; "alwaysExpanded": { "alias": "alwaysExpanded"; "required": false; "isSignal": true; }; }, {}, ["popup"], never, true, [{ directive: typeof DeferredContentAware; inputs: { "preserveContent": "preserveContent"; }; outputs: {}; }]>;
// (undocumented)
Expand All @@ -38,7 +38,7 @@ export class ComboboxDialog {
readonly combobox: Combobox<any>;
readonly element: HTMLElement;
// (undocumented)
_pattern: ComboboxDialogPattern;
readonly _pattern: ComboboxDialogPattern;
// (undocumented)
static ɵdir: _angular_core.ɵɵDirectiveDeclaration<ComboboxDialog, "dialog[ngComboboxDialog]", ["ngComboboxDialog"], {}, {}, never, never, true, [{ directive: typeof ComboboxPopup; inputs: {}; outputs: {}; }]>;
// (undocumented)
Expand All @@ -50,7 +50,7 @@ export class ComboboxInput {
constructor();
readonly combobox: Combobox<any>;
readonly element: HTMLElement;
value: _angular_core.ModelSignal<string>;
readonly value: _angular_core.ModelSignal<string>;
// (undocumented)
static ɵdir: _angular_core.ɵɵDirectiveDeclaration<ComboboxInput, "input[ngComboboxInput]", ["ngComboboxInput"], { "value": { "alias": "value"; "required": false; "isSignal": true; }; }, { "value": "valueChange"; }, never, never, true, never>;
// (undocumented)
Expand Down
34 changes: 17 additions & 17 deletions goldens/aria/listbox/index.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,24 +10,24 @@ import * as _angular_core from '@angular/core';
// @public
export class Listbox<V> {
constructor();
disabled: _angular_core.InputSignalWithTransform<boolean, unknown>;
readonly disabled: _angular_core.InputSignalWithTransform<boolean, unknown>;
readonly element: HTMLElement;
focusMode: _angular_core.InputSignal<"roving" | "activedescendant">;
readonly focusMode: _angular_core.InputSignal<"roving" | "activedescendant">;
gotoFirst(): void;
readonly id: _angular_core.InputSignal<string>;
protected items: _angular_core.Signal<OptionPattern<V>[]>;
multi: _angular_core.InputSignalWithTransform<boolean, unknown>;
orientation: _angular_core.InputSignal<"vertical" | "horizontal">;
protected readonly items: _angular_core.Signal<OptionPattern<V>[]>;
readonly multi: _angular_core.InputSignalWithTransform<boolean, unknown>;
readonly orientation: _angular_core.InputSignal<"vertical" | "horizontal">;
readonly _pattern: ListboxPattern<V>;
readonly: _angular_core.InputSignalWithTransform<boolean, unknown>;
readonly readonly: _angular_core.InputSignalWithTransform<boolean, unknown>;
// (undocumented)
scrollActiveItemIntoView(options?: ScrollIntoViewOptions): void;
selectionMode: _angular_core.InputSignal<"follow" | "explicit">;
softDisabled: _angular_core.InputSignalWithTransform<boolean, unknown>;
protected textDirection: _angular_core.Signal<_angular_cdk_bidi.Direction>;
typeaheadDelay: _angular_core.InputSignal<number>;
value: _angular_core.ModelSignal<V[]>;
wrap: _angular_core.InputSignalWithTransform<boolean, unknown>;
readonly selectionMode: _angular_core.InputSignal<"follow" | "explicit">;
readonly softDisabled: _angular_core.InputSignalWithTransform<boolean, unknown>;
protected readonly textDirection: _angular_core.Signal<_angular_cdk_bidi.Direction>;
readonly typeaheadDelay: _angular_core.InputSignal<number>;
readonly value: _angular_core.ModelSignal<V[]>;
readonly wrap: _angular_core.InputSignalWithTransform<boolean, unknown>;
// (undocumented)
static ɵdir: _angular_core.ɵɵDirectiveDeclaration<Listbox<any>, "[ngListbox]", ["ngListbox"], { "id": { "alias": "id"; "required": false; "isSignal": true; }; "orientation": { "alias": "orientation"; "required": false; "isSignal": true; }; "multi": { "alias": "multi"; "required": false; "isSignal": true; }; "wrap": { "alias": "wrap"; "required": false; "isSignal": true; }; "softDisabled": { "alias": "softDisabled"; "required": false; "isSignal": true; }; "focusMode": { "alias": "focusMode"; "required": false; "isSignal": true; }; "selectionMode": { "alias": "selectionMode"; "required": false; "isSignal": true; }; "typeaheadDelay": { "alias": "typeaheadDelay"; "required": false; "isSignal": true; }; "disabled": { "alias": "disabled"; "required": false; "isSignal": true; }; "readonly": { "alias": "readonly"; "required": false; "isSignal": true; }; "value": { "alias": "value"; "required": false; "isSignal": true; }; }, { "value": "valueChange"; }, ["_options"], never, true, [{ directive: typeof ComboboxPopup; inputs: {}; outputs: {}; }]>;
// (undocumented)
Expand All @@ -36,15 +36,15 @@ export class Listbox<V> {

// @public
class Option_2<V> {
active: _angular_core.Signal<boolean>;
disabled: _angular_core.InputSignalWithTransform<boolean, unknown>;
readonly active: _angular_core.Signal<boolean>;
readonly disabled: _angular_core.InputSignalWithTransform<boolean, unknown>;
readonly element: HTMLElement;
readonly id: _angular_core.InputSignal<string>;
label: _angular_core.InputSignal<string | undefined>;
readonly label: _angular_core.InputSignal<string | undefined>;
readonly _pattern: OptionPattern<V>;
protected searchTerm: _angular_core.Signal<string>;
protected readonly searchTerm: _angular_core.Signal<string>;
readonly selected: _angular_core.Signal<boolean | undefined>;
value: _angular_core.InputSignal<V>;
readonly value: _angular_core.InputSignal<V>;
// (undocumented)
static ɵdir: _angular_core.ɵɵDirectiveDeclaration<Option_2<any>, "[ngOption]", ["ngOption"], { "id": { "alias": "id"; "required": false; "isSignal": true; }; "value": { "alias": "value"; "required": true; "isSignal": true; }; "disabled": { "alias": "disabled"; "required": false; "isSignal": true; }; "label": { "alias": "label"; "required": false; "isSignal": true; }; }, {}, never, never, true, never>;
// (undocumented)
Expand Down
4 changes: 2 additions & 2 deletions goldens/aria/menu/index.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,9 @@ export class MenuTrigger<V> {
readonly element: HTMLElement;
readonly expanded: _angular_core.Signal<boolean>;
readonly hasPopup: _angular_core.Signal<boolean>;
menu: _angular_core.InputSignal<Menu<V> | undefined>;
readonly menu: _angular_core.InputSignal<Menu<V> | undefined>;
open(): void;
_pattern: MenuTriggerPattern<V>;
readonly _pattern: MenuTriggerPattern<V>;
readonly softDisabled: _angular_core.InputSignalWithTransform<boolean, unknown>;
readonly textDirection: _angular_core.WritableSignal<_angular_cdk_bidi.Direction>;
// (undocumented)
Expand Down
Loading
Loading