test: update vitest windows subst drive e2e test to use the ng helper and assert success - #34064
Merged
Merged
Conversation
… and assert success NG0203 dual-package hazard error no longer occurs under Vitest 5 on the subst drive.
alan-agius4
added
action: review
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the windows-subst-drive.ts end-to-end test to use the ng helper instead of execAndCaptureError when running ng test. The feedback suggests combining both stdout and stderr into the output string to ensure the test remains resilient if test runner or CLI diagnostics are written to the error stream.
JeanMeche
approved these changes
Sep 10, 2026
alan-agius4
removed
the
action: review
Collaborator
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NG0203 dual-package hazard error no longer occurs under Vitest 5 on the subst drive.