refactor(@angular/build): lazily evaluate sideEffects in javascript transformer

[clydin]

Previously, compiler-plugin.ts eagerly resolved sideEffects for every JavaScript file loaded during bundling by calling await hasSideEffects(request), which executes esbuild's asynchronous build.resolve to inspect package.json.

Within the JavaScript transformer, sideEffects is only needed in two specific locations: when checking if a file belongs to node_modules/@angular/ to apply top-level pure function annotations, and when determining whether to wrap decorators in side-effect-free files that lack primary candidate tokens.

The sideEffects check is now evaluated lazily. Method signatures on transformData and transformFile have been simplified to accept a TransformOptions interface with an optional async sideEffects resolver callback. Inside hasAdvancedOptimizationCandidates, the resolver is only evaluated if the file matches the node_modules/@angular/ path pattern or contains decorator tokens without primary optimization tokens. If the candidate check does not query sideEffects, the resolver is never invoked, eliminating unnecessary build.resolve calls for bypassed files, linker-only modules, and files matching primary optimization tokens.

[gemini-code-assist]

Code Review

This pull request refactors the JavaScriptTransformer to accept a lazy sideEffects resolver callback instead of a pre-evaluated boolean. It introduces a new TransformOptions interface to group transformation parameters, moves caching logic from transformFile to transformData to ensure both paths benefit from caching, and updates the compiler plugin and tests accordingly. There are no review comments, so no feedback is provided.

[clydin]

This PR was merged into the repository. The changes were merged into the following branches:

• main: 83264c2