fix(@angular/cli): declare devserver_start/stop as isReadOnly:false#33654
Open
herdiyana256 wants to merge 1 commit into
Open
fix(@angular/cli): declare devserver_start/stop as isReadOnly:false#33654herdiyana256 wants to merge 1 commit into
herdiyana256 wants to merge 1 commit into
Conversation
…adOnly:false Both tools are declared isReadOnly:true, so they remain registered and callable when the MCP server is started with --read-only, and MCP host clients that use readOnlyHint to auto-approve tool calls without asking the user will call them without confirmation. devserver_start spawns a background ng serve child process and binds a network port. devserver_stop sends SIGTERM to that process. Neither is a read-only operation. devserver_wait_for_build only polls status and logs of an already-running server, so it correctly stays isReadOnly:true. run_target.ts already declares isReadOnly:false for the same reason, so this aligns the two devserver lifecycle tools with the existing pattern.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
devserver_start and devserver_stop are declared isReadOnly:true, so they remain registered when the server is started with --read-only, and MCP host clients that use the readOnlyHint annotation to auto-approve tool calls without a confirmation prompt will call them without asking the user.
devserver_start spawns a background ng serve child process and binds a network port. devserver_stop sends SIGTERM to that process. Neither is a read-only operation.
devserver_wait_for_build only polls the status and logs of an already-running server, so it correctly stays isReadOnly:true and is unchanged here.
run_target.ts already declares isReadOnly:false for the same reason (it can trigger builds/tests), so this aligns the two devserver lifecycle tools with the existing pattern in the same module.