fix(@angular/cli): restrict MCP workspace access to allowed client roots during resolution#33087
Merged
alan-agius4 merged 1 commit intoangular:mainfrom Apr 30, 2026
Merged
fix(@angular/cli): restrict MCP workspace access to allowed client roots during resolution#33087alan-agius4 merged 1 commit intoangular:mainfrom
alan-agius4 merged 1 commit intoangular:mainfrom
Conversation
alan-agius4
added
action: review
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request implements path validation for MCP tools to ensure workspace paths remain within allowed roots. It updates the resolveWorkspaceAndProject utility and various tool entry points to utilize the MCP server context for root verification. The review feedback suggests improving abstraction by using server proxy methods and adding safety checks for non-file URIs when processing client roots.
amishne
approved these changes
Apr 29, 2026
alan-agius4
added
action: merge
…ots during resolution Introduces validation during workspace and project resolution to ensure the resolved workspace path falls within the allowed MCP roots defined by client capabilities. Throws an error if the workspace resolves outside the allowed roots. Closes angular#33077
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces validation during workspace and project resolution to ensure the resolved workspace path falls within the allowed MCP roots defined by client capabilities. Throws an error if the workspace resolves outside the allowed roots.
Closes #33077