test(@angular/build): add E2E test for Vitest browser mode with coverage#33058
Open
clydin wants to merge 2 commits intoangular:mainfrom
Open
test(@angular/build): add E2E test for Vitest browser mode with coverage#33058clydin wants to merge 2 commits intoangular:mainfrom
clydin wants to merge 2 commits intoangular:mainfrom
Conversation
clydin
force-pushed
the
test/vitest-browser-coverage
branch
4 times, most recently
from
7dd4c17 to
0effc83
Compare
This test ensures that stack traces map correctly to source files and that coverage reports are generated when running Vitest in browser mode with coverage enabled. This provides validation for the current implementation and will help verify future refactors removing the source-map-support dependency.
clydin
force-pushed
the
test/vitest-browser-coverage
branch
2 times, most recently
from
0005549 to
c5e3213
Compare
clydin
added
action: review
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the browser source map support plugin and its associated logic from the Vitest builder configuration, while also updating the sourcemap adjustment logic. Additionally, a new E2E test has been added to verify browser coverage. I have no feedback to provide on the code changes themselves, but please address the versioning issue identified in the E2E test file.
alan-agius4
approved these changes
Apr 28, 2026
alan-agius4
added
action: merge
This change removes the injection of `source-map-support` in Vitest browser tests and enables sourcemap rebasing for coverage runs as well. This allows Vitest's native remapper to handle stack traces and coverage correctly without needing the external polyfill in the browser. The E2E tests have been verified to pass with these changes. The unused `createSourcemapSupportPlugin` function has also been removed.
clydin
force-pushed
the
test/vitest-browser-coverage
branch
from
c5e3213 to
170f400
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test ensures that stack traces map correctly to source files and that coverage reports are generated when running Vitest in browser mode with coverage enabled. This provides validation for the current implementation and will help verify future refactors removing the source-map-support dependency.