Skip to content

build: bypass TS 6.0 deprecation warnings for rules_angular update#32979

Merged
alan-agius4 merged 1 commit into
angular:mainfrom
alan-agius4:pr-takeover-32966
Apr 10, 2026
Merged

build: bypass TS 6.0 deprecation warnings for rules_angular update#32979
alan-agius4 merged 1 commit into
angular:mainfrom
alan-agius4:pr-takeover-32966

Conversation

@alan-agius4

Copy link
Copy Markdown
Collaborator

Enable ignoreDeprecations to resolve a conflict introduced by updating rules_angular. The update fixes a version mismatch where the worker's TypeScript was prioritized over the repo's version. Compiling with the repo's TypeScript now requires this flag due to the deprecation of moduleResolution: "node".

@angular-robot angular-robot Bot added the area: build & ci Related the build and CI infrastructure of the project label Apr 10, 2026
@alan-agius4 alan-agius4 changed the title build: bypass TS 5.9 deprecation warnings for rules_angular update build: bypass TS 6.0 deprecation warnings for rules_angular update Apr 10, 2026
Enable ignoreDeprecations to resolve a conflict introduced by updating rules_angular. The update fixes a version mismatch where the worker's TypeScript was prioritized over the repo's version. Compiling with the repo's TypeScript now requires this flag due to the deprecation of moduleResolution: "node".
@alan-agius4 alan-agius4 requested review from clydin and hawkgs April 10, 2026 10:28
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: minor This PR is targeted for the next minor release labels Apr 10, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the tsconfig.json file to include the ignoreDeprecations setting. The reviewer suggests lowering the version from 6.0 to 5.0 to ensure that only relevant deprecations are suppressed without hiding future warnings.

Comment thread tsconfig.json
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 10, 2026
@alan-agius4 alan-agius4 merged commit a50cde2 into angular:main Apr 10, 2026
67 of 68 checks passed
@alan-agius4

Copy link
Copy Markdown
Collaborator Author

This PR was merged into the repository. The changes were merged into the following branches:

@alan-agius4 alan-agius4 deleted the pr-takeover-32966 branch April 10, 2026 11:30
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators May 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants