This repository was archived by the owner on May 25, 2019. It is now read-only.
[RFR] Fix Strict DI issues and remove ngAnnotate#127
Open
jpetitcolas wants to merge 1 commit intoangular-ui:masterfrom
Open
[RFR] Fix Strict DI issues and remove ngAnnotate#127jpetitcolas wants to merge 1 commit intoangular-ui:masterfrom
jpetitcolas wants to merge 1 commit intoangular-ui:masterfrom
Conversation
Author
|
Fixes #106. |
|
Not sure why removing ng-annotate is the solution here. I figure it should work with ng-annotate as expected in npm as long as the main file points to the Also, why aren't these PRs reviewed? Looks like this hasn't been touched for a year. |
Author
|
What is the status of this PR. It has been almost a year and this fix is necessary for us. Let me know if there is anything that needs to be done to allow it to get merged in. |
Author
|
Same here. We got a production project using my fork as a dependency. That's not really comfortable. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to solve an issue when importing this module in a Strict Dependency Injection environment. Indeed, using current version, installed with
npm, we get the following Angular error:Bower version is not impacted as
ng-annotateplugin seems to be used in this case.As source file is already compatible with strict DI, I also removed the obsolete
ng-annotateplugin.