This repository was archived by the owner on May 25, 2019. It is now read-only.
Added missing string literals for minification#100
Open
jpreecedev wants to merge 2 commits intoangular-ui:masterfrom
Open
Added missing string literals for minification#100jpreecedev wants to merge 2 commits intoangular-ui:masterfrom
jpreecedev wants to merge 2 commits intoangular-ui:masterfrom
Conversation
|
+1, can we have this merged? |
Author
|
I think the project is stale, there has been no activity for a while. shame. |
|
This really need to be merged. @douglasduteil |
Contributor
|
Hi guys sorry I been far for the Angular UI community for a while now... I will try to merge stuff tomorrow but if any of you guys are using this, and have the time to take care of it, feel free to contact me to become contributors so you can make it evolve faster... |
|
👍 |
|
Hey, a colleague and I would be happy to do a couple of bits of work, merge a couple of PRs to get this moving. That work for you? |
|
Hi @douglasduteil, this PR is pretty important to ensure ui-codemirror works with minification. Please can we get this merged? 😄 |
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added missing string literals for minification