-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat(oauth): multiple strategies per account; changeable email #392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Not sure that we should enable any oauth strategies by default, they each take a bit of work to set up (setting up google/twitter/facebook oauth secrets/ids, and adding the environment variables) |
|
It's only selected by default for people who want oauth in app they are about to generate. Also not setting key/secrets won't brake anything, only " Connect with *" buttons won't work. |
|
Well actually, the way its written, they're selected by default for anyone who uses authentication in their app. Idk, I just think the defaults should all pretty much work out of the box. So this is something that should go into the next minor version. I'm thinking it would be good to setup a branch specifically for features that are going into the next minor version, so we can continue releasing patches until the minor version is ready to be released. I'm going to create a A couple things I'd like to go into the next version would be to add support for sequelize as an alternative to mongoose, and perhaps support for password recovery emails, based on remi's PR for modular-fs. Nice work with this btw! |
|
I'm working on a PR for mail address confirmation (through mail) and password recovery for the generator. The WIP can be seen here: in https://github.com/remicastaing/generator-angular-fullstack/tree/mail. +1 for |
|
@DaftMonk Yes, I agree, anything I should do? |
|
Merged into canary. |
|
Why was this reverted? |
You will find the answer here: #492 |
Changes include:
change emailin settings,set passwordafter register through oauth,confirmuser's emails,Googlescope updated to match with migration guide,defaultoptions removed in some places,angular injectionsremoved,Breaking:
strategiesobject onUsermodel),emailorphone) are now moved tocredentialsobjectarray inUsermodel (Helps with keeping track of states of individual methods and having multiple of them).TODO:
manually linkoauthaccounts from settings,email hooksin where relevant.¹ - I'll be adding more networks and they'll be disabled by default