Skip to content

Conversation

@christophbuermann
Copy link
Collaborator

Fixed

  • Use timezone.now() instead of datetime.now() in PeriodicFutureTask.save().
  • Use condition instead of check attribute in CheckConstraint.

Added

  • Support for Python 3.14.
  • Support for Django 5.2.

Removed

  • Support for Python 3.9.
  • Support for Django 5.0.

@christophbuermann christophbuermann force-pushed the update_to_python_3_14_dango_5_2 branch 2 times, most recently from b480f35 to 8d1488f Compare October 10, 2025 15:29
@christophbuermann christophbuermann force-pushed the update_to_python_3_14_dango_5_2 branch from 8d1488f to f564ec4 Compare October 10, 2025 15:37
Copy link
Collaborator Author

@christophbuermann christophbuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This pull request depends on and is based on: #16

Comment on lines -73 to +92
[Unreleased]: https://github.com/anexia/django-future-tasks/compare/1.3.0...HEAD
[Unreleased]: https://github.com/anexia/django-future-tasks/compare/1.3.2...HEAD
[1.3.2]: https://github.com/anexia/django-future-tasks/releases/tag/1.3.2
[1.3.1]: https://github.com/anexia/django-future-tasks/releases/tag/1.3.1
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found the unreleased section. 🙃 I can change this in the other pull request and rebase next week.

Comment on lines +31 to +32
)
if django.VERSION < (5, 1)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

condition does not exist in 4.2 and check is deprecated in 5.1. 🙃
Changing the name seems to be not a change in the database - makemigrations says no changes.

Comment on lines -137 to +133
self.last_task_creation = datetime.datetime.now()
self.last_task_creation = timezone.now()
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be the cause of the duplicated tasks that you encountered @nezhar .


[tool.pytest.ini_options]
DJANGO_SETTINGS_MODULE = "core.settings"
filterwarnings = ["error", "ignore::ResourceWarning"]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a ResourceWarning that sometimes pop up in the tests because of an unclosed connection to SQLite that I don't really care about.

Comment on lines +66 to +68
[tool.ruff.lint]
select = ["A", "B", "C", "E", "F", "W", "T20", "LOG", "I", "UP", "RUF010", "RUF019"]
ignore = ["E203", "E266", "E501", "F403", "F405"]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I threw our usual config in there after noticing that imports were not automatically sorted and fixed all the issues that popped up because of the stricter config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants