-
Notifications
You must be signed in to change notification settings - Fork 3
Add support for Python 3.14 + Django 5.2 + drop end-of-life versions #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add support for Python 3.14 + Django 5.2 + drop end-of-life versions #17
Conversation
b480f35 to
8d1488f
Compare
8d1488f to
f564ec4
Compare
christophbuermann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| [Unreleased]: https://github.com/anexia/django-future-tasks/compare/1.3.0...HEAD | ||
| [Unreleased]: https://github.com/anexia/django-future-tasks/compare/1.3.2...HEAD | ||
| [1.3.2]: https://github.com/anexia/django-future-tasks/releases/tag/1.3.2 | ||
| [1.3.1]: https://github.com/anexia/django-future-tasks/releases/tag/1.3.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found the unreleased section. 🙃 I can change this in the other pull request and rebase next week.
| ) | ||
| if django.VERSION < (5, 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
condition does not exist in 4.2 and check is deprecated in 5.1. 🙃
Changing the name seems to be not a change in the database - makemigrations says no changes.
| self.last_task_creation = datetime.datetime.now() | ||
| self.last_task_creation = timezone.now() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be the cause of the duplicated tasks that you encountered @nezhar .
|
|
||
| [tool.pytest.ini_options] | ||
| DJANGO_SETTINGS_MODULE = "core.settings" | ||
| filterwarnings = ["error", "ignore::ResourceWarning"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a ResourceWarning that sometimes pop up in the tests because of an unclosed connection to SQLite that I don't really care about.
| [tool.ruff.lint] | ||
| select = ["A", "B", "C", "E", "F", "W", "T20", "LOG", "I", "UP", "RUF010", "RUF019"] | ||
| ignore = ["E203", "E266", "E501", "F403", "F405"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I threw our usual config in there after noticing that imports were not automatically sorted and fixed all the issues that popped up because of the stricter config.
Fixed
timezone.now()instead ofdatetime.now()inPeriodicFutureTask.save().conditioninstead ofcheckattribute inCheckConstraint.Added
Removed