Extract sample shared KMP code into :sample:shared submodule#182
Open
kirich1409 wants to merge 4 commits intomainfrom
Open
Extract sample shared KMP code into :sample:shared submodule#182kirich1409 wants to merge 4 commits intomainfrom
kirich1409 wants to merge 4 commits intomainfrom
Conversation
Move sample/src/ into sample/shared/ and register it as :sample:shared instead of :sample. Update :sample:android-app dependency accordingly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one. |
- Add standalone :sample:desktop JVM application module - Move Main.Desktop.kt from :sample:shared jvmMain to :sample:desktop - Remove compose.desktop and jvmMain from :sample:shared (library, not app) - Delete legacy :sample module (sample/src/, sample/build.gradle.kts) - Refactor SampleViewModel: extract observeValue() to reduce stateIn boilerplate - Fix MainViewController to use SampleApp instead of FeaturedSample directly Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Add T : Any bound to observeValue extension (ConfigValues.observe requires it) - Reformat method chains in SampleViewModel to satisfy spotless - Update iosApp.xcodeproj: Gradle task and framework paths now point to :sample:shared
Removes private observeValue extension that duplicated ConfigValuesExtensions. Four stateIn() blocks replaced with asStateFlow() from the same file.
Contributor
Author
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sample/src/intosample/shared/src/:sample:sharedinstead of:sample:sample:android-appdependency from:sampleto:sample:sharedTest plan
:sample:shared:assemblebuilds successfully:sample:android-app:assembleDebugbuilds successfully