Extracted Code Snippets for Architecture - UILayer.kt - #1101
Open
djubinville wants to merge 1 commit into
Open
djubinville wants to merge 1 commit into
djubinville wants to merge 1 commit into
Conversation
djubinville
requested review from
srikrishnasakunia
and removed request for
a team
September 15, 2026 23:16
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
djubinville
changed the title
https://developer.android.com/topic/architecture/ui-layer cc @kkuan2011 List of modifications: UI layer page: Migrated 8 Kotlin code snippets to compose/snippets/src/main/java/com/example/compose/snippets/architecture/UiLayer.kt: android_architecture_ui_layer_news_ui_state android_architecture_ui_layer_viewmodel_expose_state android_architecture_ui_layer_viewmodel_mutable_state android_architecture_ui_layer_viewmodel_fetch_articles android_architecture_ui_layer_news_can_bookmark android_architecture_ui_layer_news_fetching_state android_architecture_ui_layer_latest_news_screen android_architecture_ui_layer_news_user_messages UI layer page: In android_architecture_ui_layer_viewmodel_expose_state, applied the D23 twin pattern on val uiState: NewsUiState = /* ... */ with silent exclude for compiling NewsUiState() to ensure clean compilation while preserving the placeholder on DAC per review feedback. Cleaned up .gitignore to omit local reports/ directory. Snippets not migrated: None; all 8 snippets on the page were migrated.
djubinville
force-pushed
the
katherinekuan/ui-layer-snippets
branch
from
September 16, 2026 20:24
05671ed to
6294e3a
Compare
kkuan2011
reviewed
Sep 17, 2026
kkuan2011
left a comment
kkuan2011
left a comment
Contributor
There was a problem hiding this comment.
When I click on "Files changed", I don't see the new snippets you added. Is the diff showing up for you as you expect?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted code snippets for page:
https://developer.android.com/topic/architecture/ui-layer
in file:
compose/snippets/src/main/java/com/example/compose/snippets/architecture/UiLayer.ktList of modifications:
UI layer page: Migrated 8 Kotlin code snippets to
android_architecture_ui_layer_news_ui_stateandroid_architecture_ui_layer_viewmodel_expose_stateandroid_architecture_ui_layer_viewmodel_mutable_stateandroid_architecture_ui_layer_viewmodel_fetch_articlesandroid_architecture_ui_layer_news_can_bookmarkandroid_architecture_ui_layer_news_fetching_stateandroid_architecture_ui_layer_latest_news_screenandroid_architecture_ui_layer_news_user_messagesUI layer page: In
android_architecture_ui_layer_viewmodel_expose_state, applied the D23 twin pattern onval uiState: NewsUiState = /* ... */with silent exclude for compilingNewsUiState()to ensure clean compilation while preserving the placeholder on DAC per review feedback.Snippets not migrated:
None; all 8 snippets on the page were migrated.
cc: @kkuan2011