Skip to content

Migrate Control external devices snippets - #1081

Merged
alabiaga merged 4 commits into
android:mainfrom
hamen:hamen/device-control
Sep 18, 2026
Merged

alabiaga merged 4 commits into
android:mainfrom
hamen:hamen/device-control

Conversation

@hamen

@hamen hamen commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Code snippets are for:

List of modifications:

  • Device-control page: Added ControlsProviderService implementation with reactive flows and control actions.
  • Device-control page: Formatted elisions as // ... per D22 with silent excludes for compiling fidelity.
  • Device-control page: Replaced hardcoded snippets on DAC with github.code_snippet macros.

Snippets not migrated:

  • Snippet 1 (line 142): AndroidManifest.xml service declaration.
  • Snippet 4 (line 336): Gradle build configuration dependencies block.

@hamen
hamen marked this pull request as ready for review September 15, 2026 13:38
@snippet-bot

snippet-bot Bot commented Sep 15, 2026

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 5 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@kkuan2011 kkuan2011 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after comments addressed, then you can add Aaron

Comment thread views/build.gradle.kts Outdated
@hamen

hamen commented Sep 16, 2026

Copy link
Copy Markdown
Contributor Author

@kkuan2011 Thanks for the review! All 4 comments have been addressed in eeaf10a (verified with spotlessApply and compileDebugKotlin).

cc @alabiaga for review when you have a moment.

@kkuan2011
kkuan2011 requested a review from alabiaga September 17, 2026 23:26
@alabiaga
alabiaga merged commit 513f824 into android:main Sep 18, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants