Conversation
kkuan2011
approved these changes
Sep 15, 2026
kkuan2011
left a comment
Contributor
There was a problem hiding this comment.
Looks good once comments are addressed, then can you add Aaron for review? and move it out of draft mode?
The Snackbar snippets call findViewById(R.id.myCoordinatorLayout). The id came from an ids.xml entry, which declares an id that no layout uses. The showing page already carries the layout the snippets expect, so migrate that block too and let it declare the id. The page still shows android.support.design.widget.CoordinatorLayout. The snippet uses the AndroidX class.
hamen
force-pushed
the
hamen/snackbar-showing
branch
from
September 16, 2026 14:41
58deebb to
1ed0555
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code snippets are for:
List of modifications:
viewsmodule).viewsmodule). It declares@+id/myCoordinatorLayout, which the chainedSnackbar.make()snippet looks up.viewsandcompose:snippetsmodules).Deviations from the page:
androidx.coordinatorlayout.widget.CoordinatorLayout. The page showsandroid.support.design.widget.CoordinatorLayout, which is the Support Library class and is no longer available. The page text needs the same change.xmlns:appdeclaration.