Skip to content

Fix grammar in search empty-state copy ("explorer" -> "explore") #2129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Amir-yazdanmanesh wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

Fix grammar in search empty-state copy ("explorer" -> "explore") #2129

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion feature/search/api/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
<string name="feature_search_api_clear_search_text_content_desc">Clear search text</string>
<string name="feature_search_api_result_not_found">Sorry, there is no content found for your search \"%1$s\"</string>
<string name="feature_search_api_not_ready">Sorry, we are still processing the search index. Please come back later</string>
<string name="feature_search_api_try_another_search">Try another search or explorer </string>
<string name="feature_search_api_try_another_search">Try another search or explore </string>

@gemini-code-assist gemini-code-assist Bot Jun 12, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The string resource feature_search_api_try_another_search contains a trailing space. However, in SearchScreen.kt (line 233), an explicit space is already appended:

append(stringResource(id = searchR.string.feature_search_api_try_another_search))
append(" ")

This results in a double space in the rendered UI (i.e., Try another search or explore Interests). Removing the trailing space from the string resource resolves this issue and keeps the resource clean.

Suggested change
<string name="feature_search_api_try_another_search">Try another search or explore </string>
<string name="feature_search_api_try_another_search">Try another search or explore</string>

<string name="feature_search_api_interests">Interests</string>
<string name="feature_search_api_to_browse_topics"> to browse topics</string>
<string name="feature_search_api_topics">Topics</string>
Expand Down