[BrushGraph 7/7] Integrate Brush Graph into the app#66
Open
maxmmitchell wants to merge 5 commits intobrush-graph/6-canvasfrom
Open
[BrushGraph 7/7] Integrate Brush Graph into the app#66maxmmitchell wants to merge 5 commits intobrush-graph/6-canvasfrom
maxmmitchell wants to merge 5 commits intobrush-graph/6-canvasfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive "Brush Graph" feature, a node-based visual designer for ink brushes. It includes a new navigation destination, a complex UI with canvas, inspector, and notification panes, and a tutorial system. Key technical changes include the addition of an ExtendedColorScheme for warning states, Hilt injection for the texture store, and autosave functionality in the drawing canvas. Review feedback highlights critical issues with texture serialization due to incorrect store instantiation, potential UI freezes from blocking I/O on the main thread, and opportunities for code cleanup regarding unused parameters and magic strings.
maxmmitchell
force-pushed
the
brush-graph/7-integration
branch
3 times, most recently
from
b5d3f01 to
feb8bd6
Compare
maxmmitchell
force-pushed
the
brush-graph/6-canvas
branch
from
bcf7952 to
53d3ee1
Compare
maxmmitchell
force-pushed
the
brush-graph/7-integration
branch
from
feb8bd6 to
d599cde
Compare
maxmmitchell
force-pushed
the
brush-graph/6-canvas
branch
2 times, most recently
from
5bc8df0 to
261113b
Compare
maxmmitchell
force-pushed
the
brush-graph/7-integration
branch
from
d599cde to
b512362
Compare
maxmmitchell
force-pushed
the
brush-graph/6-canvas
branch
from
261113b to
d64bb5a
Compare
maxmmitchell
force-pushed
the
brush-graph/7-integration
branch
from
b512362 to
7903aa3
Compare
cka-dev
requested changes
Apr 30, 2026
| dialogSlot() | ||
|
|
||
| BoxWithConstraints(modifier = modifier.fillMaxSize()) { | ||
| val currentIsLandscape = maxWidth > maxHeight |
| modifier: Modifier = Modifier, | ||
| ) { | ||
| val context = LocalContext.current | ||
| var showMoreMenu by remember { mutableStateOf(false) } |
Contributor
There was a problem hiding this comment.
All of these can be remberSaveable, so to survive configuration changes
| onExport: () -> Unit, | ||
| onLoadBrushFile: () -> Unit, | ||
| onSaveToPalette: () -> Unit, | ||
| textureStore: TextureBitmapStore, |
Contributor
There was a problem hiding this comment.
this was never and might not be needed
| class BrushGraphViewModel @Inject constructor( | ||
| private val customBrushDao: CustomBrushDao, | ||
| private val textureStore: CahierTextureBitmapStore, | ||
| public val textureStore: CahierTextureBitmapStore, |
maxmmitchell
force-pushed
the
brush-graph/6-canvas
branch
2 times, most recently
from
d2d8890 to
b23afd0
Compare
maxmmitchell
force-pushed
the
brush-graph/7-integration
branch
3 times, most recently
from
42ec480 to
46afe97
Compare
maxmmitchell
force-pushed
the
brush-graph/6-canvas
branch
2 times, most recently
from
727bc59 to
c2505db
Compare
maxmmitchell
force-pushed
the
brush-graph/7-integration
branch
from
46afe97 to
92d7925
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is the final PR in the Brush Graph stack. It ties all the components together and integrates the feature into the main application navigation and resource files.
Details
DisplayTextExtensions).CahierNavGraph, as a default-on toggle which controls whether the "Launch" button next to Brush Designer leads to tab-based or graph-based view.Dependencies
brush-graph/6-canvas