[BrushGraph 3/7] Add ViewModel and state management#62
Open
maxmmitchell wants to merge 7 commits intobrush-graph/2-persistencefrom
Open
[BrushGraph 3/7] Add ViewModel and state management#62maxmmitchell wants to merge 7 commits intobrush-graph/2-persistencefrom
maxmmitchell wants to merge 7 commits intobrush-graph/2-persistencefrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the BrushGraphViewModel and TutorialManager to handle the logic for a brush graph editor, including node/edge management, tutorial progression, and brush palette persistence. Feedback focuses on optimizing the brush StateFlow to prevent unnecessary re-calculations during UI interactions, improving encapsulation by making internal dependencies private, and removing unused parameters. Additionally, the reviewer suggested replacing println with proper Android logging and simplifying the palette API by removing redundant parameters.
maxmmitchell
force-pushed
the
brush-graph/3-viewmodel
branch
from
5a37541 to
a4e196f
Compare
maxmmitchell
force-pushed
the
brush-graph/2-persistence
branch
4 times, most recently
from
4f5748b to
bd61e05
Compare
maxmmitchell
force-pushed
the
brush-graph/3-viewmodel
branch
from
a4e196f to
e17146a
Compare
maxmmitchell
force-pushed
the
brush-graph/2-persistence
branch
from
bd61e05 to
da9bc38
Compare
maxmmitchell
force-pushed
the
brush-graph/3-viewmodel
branch
from
e17146a to
cc0aecc
Compare
cka-dev
approved these changes
Apr 30, 2026
maxmmitchell
force-pushed
the
brush-graph/2-persistence
branch
from
257bd46 to
c7b9a0d
Compare
maxmmitchell
force-pushed
the
brush-graph/3-viewmodel
branch
2 times, most recently
from
8157b89 to
4f012bf
Compare
maxmmitchell
force-pushed
the
brush-graph/2-persistence
branch
3 times, most recently
from
9abf30a to
ee09998
Compare
maxmmitchell
force-pushed
the
brush-graph/3-viewmodel
branch
from
4f012bf to
4ebcb7e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is the third PR in the Brush Graph stack. It introduces the state management layer that bridges the data layer with the upcoming UI.
Details
BrushGraphUiState: Holds the current graph, selected nodes, camera position, and tutorial state.TutorialManager, listens to user actions (like adding a node) and advances the tutorial state automatically.Dependencies
brush-graph/2-persistence